Magento_Catalog: avoid using deprecated escape* methods from Abstract… by sergeynezbritskiy · Pull Request #31684 · magento/magento2

sergeynezbritskiy · 2021-01-16T16:08:32Z

Description (*)

Avoid using deprecated escape* methods from AbstractBlock

Related Pull Requests

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-01-16T16:08:35Z

Hi @sergeynezbritskiy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.5-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

ihor-sviziev · 2021-01-21T09:09:10Z

@magento run all tests

ihor-sviziev · 2021-01-29T13:00:54Z

@magento run Functional Tests CE, Functional Tests EE, Static Tests, Integration Tests

ihor-sviziev

Could you review my comments and apply similar changes to all changed files?

...de/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options.phtml

.../Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/date.phtml

...talog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/default.phtml

.../Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/file.phtml

...atalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/select.phtml

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/helper/gallery.phtml

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/js.phtml

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/tab/alert.phtml

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/tab/inventory.phtml

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/inventory.phtml

…Block

sergeynezbritskiy · 2021-02-11T13:23:15Z

Hello @ihor-sviziev I've fixed the issues you mentioned above, including files not affected directly by adding $escaper to templates, please review

engcom-Charlie · 2021-02-11T19:00:10Z

@magento run all tests

ihor-sviziev · 2021-02-17T08:12:44Z

@magento run Database Compare, Functional Tests CE, Functional Tests EE, Integration Tests

ihor-sviziev · 2021-02-17T10:51:52Z

@magento run Integration Tests

ihor-sviziev · 2021-02-18T10:48:50Z

@magento run Integration Tests

m2-assistant · 2021-03-09T08:25:37Z

Hi @sergeynezbritskiy. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.5-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

ihor-sviziev · 2021-03-09T08:26:03Z

Just closed and re-opened this PR in order to fix missing CLA check

sergeynezbritskiy · 2021-03-09T12:09:06Z

@magento run Integration Tests, WebAPI Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B, Database Compare

ihor-sviziev · 2021-03-10T07:41:40Z

@magento run Integration Tests, Functional Tests B2B, Database Compare

ihor-sviziev

Could you check the integration test failures? It seems like your changes did some regression

sergeynezbritskiy · 2021-03-19T07:28:25Z

@magento run Integration Tests

sergeynezbritskiy · 2021-03-19T08:24:30Z

Hello @ihor-sviziev I'm trying to run Integration Tests but they are failing after 2 min with no reports. The message says that I should address this issue to community engineering team. Please suggest
Thanks in advance

ihor-sviziev · 2021-03-19T09:56:14Z

@sergeynezbritskiy could you resolve conflicts? It might be reason why it fails

ihor-sviziev · 2021-04-04T09:08:10Z

@magento run all tests

ihor-sviziev

✔ Approved.

Failing tests looks not related to changes from this PR.

magento-engcom-team · 2021-04-05T05:52:46Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8984 has been created to process this Pull Request

m2-community-project bot added the Progress: pending review label Jan 16, 2021

sergeynezbritskiy mentioned this pull request Jan 16, 2021

avoid using deprecated escape* methods from AbstractBlock #31610

Closed

4 tasks

magento-engcom-team added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jan 20, 2021

sdzhepa mentioned this pull request Jan 20, 2021

avoid using deprecated escape* methods from AbstractBlock #31789

Closed

72 tasks

magento-engcom-team added this to the 2.5 milestone Jan 20, 2021

ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 21, 2021

ihor-sviziev self-assigned this Jan 21, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jan 21, 2021

ihor-sviziev mentioned this pull request Jan 21, 2021

Use $escaper for XSS prevention #31391

Closed

4 tasks

gabrieldagama added up for grabs and removed up for grabs labels Jan 22, 2021

ihor-sviziev requested changes Feb 8, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Feb 8, 2021

engcom-Charlie assigned engcom-Charlie and unassigned engcom-Charlie Feb 10, 2021

Magento_Catalog: Avoid using deprecated escape* methods from Abstract…

7f5e7e3

…Block

m2-community-project bot added Progress: review and removed Progress: needs update labels Feb 11, 2021

engcom-Charlie requested a review from ihor-sviziev February 11, 2021 13:33

m2-community-project bot removed the Progress: review label Mar 9, 2021

ihor-sviziev added the Progress: review label Mar 9, 2021

ihor-sviziev requested changes Mar 10, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Mar 10, 2021

Merge remote-tracking branch 'origin/2.5-develop' into HEAD

7a6b783

ihor-sviziev added the Progress: review label Apr 4, 2021

m2-community-project bot removed the Progress: needs update label Apr 4, 2021

ihor-sviziev approved these changes Apr 5, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Apr 5, 2021

magento-engcom-team added Community Insider: Magecom community-insider-contribution Area: Frontend Component: Catalog labels Apr 5, 2021

m2-community-project bot added Progress: needs update and removed Progress: ready for testing labels Apr 5, 2021

sergeynezbritskiy closed this by deleting the head repository Feb 19, 2023

m2-community-project bot removed the Progress: needs update label Feb 19, 2023

Conversation

sergeynezbritskiy commented Jan 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jan 16, 2021

Uh oh!

ihor-sviziev commented Jan 21, 2021

Uh oh!

ihor-sviziev commented Jan 29, 2021

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sergeynezbritskiy commented Feb 11, 2021

Uh oh!

engcom-Charlie commented Feb 11, 2021

Uh oh!

ihor-sviziev commented Feb 17, 2021

Uh oh!

ihor-sviziev commented Feb 17, 2021

Uh oh!

ihor-sviziev commented Feb 18, 2021

Uh oh!

m2-assistant bot commented Mar 9, 2021

Uh oh!

ihor-sviziev commented Mar 9, 2021

Uh oh!

sergeynezbritskiy commented Mar 9, 2021

Uh oh!

ihor-sviziev commented Mar 10, 2021

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

sergeynezbritskiy commented Mar 19, 2021

Uh oh!

sergeynezbritskiy commented Mar 19, 2021

Uh oh!

ihor-sviziev commented Mar 19, 2021

Uh oh!

ihor-sviziev commented Apr 4, 2021

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Apr 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sergeynezbritskiy commented Jan 16, 2021 •

edited

Loading